-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import WebDriver BiDi data #25804
base: main
Are you sure you want to change the base?
Import WebDriver BiDi data #25804
Conversation
25e4895
to
9d495c8
Compare
@@ -80,6 +80,10 @@ | |||
"type": "boolean", | |||
"description": "Whether the browser supports extensions." | |||
}, | |||
"implements_webdriver_bidi": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we use "accepts_webdriver_bidi"
to match "accepts_webextensions"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a has
array enum field that supports values flags
, webextension
and webdriver-bidi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@queengooborg I opened #25825 to merge the accepts_*
fields into an accepts
array field.
@OrKoN for the initial import of the WebDriver BiDi it would be great to also have the version information for Chrome. Would one of you have the time to update the implementation status spreadsheet with the information? That should be faster than having to manually edit later on. Thanks! |
Hi Henrik, thanks for the ping. We could update it by the end of next week, would it be possible to delay landing the data until then? |
I updated the features' status and started adding versions, but I wonder if the versions are actually needed? |
Thank you @sadym-chromium. Yes, the versions that we at least would need are for the initial support of a feature. For individual parameters we do not want to track the version (as what I got from Claas). |
done |
Thanks! I also have to correct myself. There are actually thoughts to also include the version when parameters were added, (changed?) and removed. It's actually targeted for a later milestone, but if we want we could already start adding it as well. |
Summary
Imports support data for WebDriver BiDi under
webdriver.bidi
.Bundled changes:
implements_webdriver_bidi
to browser schema.Test results and supporting details
The data was extracted using Google Apps Script on a Google Spreadsheet used by WebDriver BiDi folks to track implementation status.
Related issues
Fixes #20207.