Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import WebDriver BiDi data #25804

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Import WebDriver BiDi data #25804

wants to merge 4 commits into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 29, 2025

Summary

Imports support data for WebDriver BiDi under webdriver.bidi.

Bundled changes:

  • Adds property implements_webdriver_bidi to browser schema.
  • Uses the property to restrict the data to Chrome/Edge/Firefox/Safari.

Test results and supporting details

The data was extracted using Google Apps Script on a Google Spreadsheet used by WebDriver BiDi folks to track implementation status.

Related issues

Fixes #20207.

@github-actions github-actions bot added data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver size:xl [PR only] >1000 LoC changed schema Isses or pull requests regarding the JSON schema files used in this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. labels Jan 29, 2025
@github-actions github-actions bot added the scripts Issues or pull requests regarding the scripts in scripts/. label Jan 29, 2025
@caugner caugner force-pushed the 20207-webdriver-bidi branch from 25e4895 to 9d495c8 Compare January 29, 2025 16:45
@caugner caugner changed the title DNM: WebDriver BiDi data Import WebDriver BiDi data Jan 29, 2025
@caugner caugner requested a review from Elchi3 January 29, 2025 16:58
@@ -80,6 +80,10 @@
"type": "boolean",
"description": "Whether the browser supports extensions."
},
"implements_webdriver_bidi": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we use "accepts_webdriver_bidi" to match "accepts_webextensions"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a has array enum field that supports values flags, webextension and webdriver-bidi?

Copy link
Contributor Author

@caugner caugner Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg I opened #25825 to merge the accepts_* fields into an accepts array field.

@whimboo
Copy link
Contributor

whimboo commented Jan 30, 2025

@OrKoN for the initial import of the WebDriver BiDi it would be great to also have the version information for Chrome. Would one of you have the time to update the implementation status spreadsheet with the information? That should be faster than having to manually edit later on. Thanks!

@OrKoN
Copy link

OrKoN commented Jan 31, 2025

@OrKoN for the initial import of the WebDriver BiDi it would be great to also have the version information for Chrome. Would one of you have the time to update the implementation status spreadsheet with the information? That should be faster than having to manually edit later on. Thanks!

Hi Henrik, thanks for the ping. We could update it by the end of next week, would it be possible to delay landing the data until then?

@sadym-chromium
Copy link

@OrKoN for the initial import of the WebDriver BiDi it would be great to also have the version information for Chrome. Would one of you have the time to update the implementation status spreadsheet with the information? That should be faster than having to manually edit later on. Thanks!

I updated the features' status and started adding versions, but I wonder if the versions are actually needed?

@whimboo
Copy link
Contributor

whimboo commented Feb 6, 2025

I updated the features' status and started adding versions, but I wonder if the versions are actually needed?

Thank you @sadym-chromium. Yes, the versions that we at least would need are for the initial support of a feature. For individual parameters we do not want to track the version (as what I got from Claas).

@sadym-chromium
Copy link

I updated the features' status and started adding versions, but I wonder if the versions are actually needed?

Thank you @sadym-chromium. Yes, the versions that we at least would need are for the initial support of a feature. For individual parameters we do not want to track the version (as what I got from Claas).

done

@whimboo
Copy link
Contributor

whimboo commented Feb 10, 2025

Thank you @sadym-chromium. Yes, the versions that we at least would need are for the initial support of a feature. For individual parameters we do not want to track the version (as what I got from Claas).

done

Thanks! I also have to correct myself. There are actually thoughts to also include the version when parameters were added, (changed?) and removed. It's actually targeted for a later milestone, but if we want we could already start adding it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:webdriver Compat data for WebDriver features. https://developer.mozilla.org/docs/Web/WebDriver infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/. size:xl [PR only] >1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get WebDriver BiDi compatibility data added
5 participants