-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data for legacy version of webextension.api.userScripts #25857
Open
rebloor
wants to merge
2
commits into
mdn:main
Choose a base branch
from
rebloor:Bug-1943050-userScripts-API-legacy-content
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−9
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| { | ||
| "webextensions": { | ||
| "api": { | ||
| "userScripts_legacy": { | ||
| "__compat": { | ||
| "description": "userScripts (Legacy)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68", | ||
| "notes": "Only available for use in extensions using Manifest V2." | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| }, | ||
| "RegisteredUserScript": { | ||
| "__compat": { | ||
| "description": "RegisteredUserScript (Legacy)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| }, | ||
| "unregister": { | ||
| "__compat": { | ||
| "description": "unregister (Legacy)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "onBeforeScript": { | ||
| "__compat": { | ||
| "description": "onBeforeScript (Legacy)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } | ||
| }, | ||
| "register": { | ||
| "__compat": { | ||
| "description": "register (Legacy)", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| }, | ||
| "cookieStoreId": { | ||
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "98" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebloor, I'm curious about your motivations for including "(Legacy)" on each of the entries in this data. Is this an established practice? I assume this affects how entries appear in compatibility tables. Does it affect anything else on MDN? Other tooling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware, we haven't had a similar situation in the past, so we're inventing "practice" here. In this situation, we have a
userScriptAPI implemented in Firefox only for Manifest V2 and an incompatibleuserScriptAPI for Manifest V3 implemented in Firefox, Chrome, and Safari. In the MDN documentation readers will see the Firefox only version of the API marked up as "legacy" throughout. See mdn/content#37975descriptionis used as the title in the compatibility tables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have suggested this. If we render the BCD table for this feature, there would be no indication otherwise that this refers to the old API.
I notice that the features have no status set (like experimental, deprecated), which presumably is a special treatment. If it is forbidden to mark a webextensions.api feature as deprecated, then we should probably change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a change I'm unaware of, we have no plans to deprecate Manifest V2 ((https://blog.mozilla.org/addons/2024/03/13/manifest-v3-manifest-v2-march-2024-update/) so by extension we presumably have no plans to deprecate the Manifest V2 version of
userScript. @Rob--WIn addition to including the word legacy in the descriptions, wouldn't the
mdn_urlindicate that it refers to the legacy API?