Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-XHRify OfflineAudioContext examples #30418

Merged
merged 3 commits into from
Nov 21, 2023
Merged

De-XHRify OfflineAudioContext examples #30418

merged 3 commits into from
Nov 21, 2023

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Nov 21, 2023 •
edited
Loading

Part of #30131.

This updates two pages under https://developer.mozilla.org/en-US/docs/Web/API/OfflineAudioContext/, were using XHR in their examples.

This PR aligns the pages with the example updates that were made in http://github.com/mdn/webaudio-examples/pull/116.

@wbamberg wbamberg requested a review from a team as a code owner November 21, 2023 01:10
@wbamberg wbamberg requested review from Elchi3 and removed request for a team November 21, 2023 01:10
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/API/OfflineAudioContext
Title: OfflineAudioContext

URL: /en-US/docs/Web/API/OfflineAudioContext/startRendering
Title: OfflineAudioContext: startRendering() method

(comment last updated: 2023-11-21 01:56:07)

@wbamberg wbamberg marked this pull request as draft November 21, 2023 01:24
@wbamberg wbamberg marked this pull request as ready for review November 21, 2023 01:51
@teoli2003 teoli2003 requested review from teoli2003 and removed request for Elchi3 November 21, 2023 07:27
teoli2003
teoli2003 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 0223999 into mdn:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @teoli2003