-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect jsx attribute name
AST
#425
Conversation
🦋 Changeset detectedLatest commit: 2e86462 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 196 196
Branches 40 40
=========================================
Hits 196 196 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'll do some investigation ASAP. ESLint compatible AST could really be different with the acorn's. I don't remember why I wrote like that. 😅 |
I just noticed that ESLint failed to lint mdx now with the latest
eslint-plugin-react
here webpack/webpack.js.org#6377.Here's an example mdx file:
Here's the ast
eslint-plugin-react
would print for<div className='hi'>hello</div>
node (https://github.com/jsx-eslint/eslint-plugin-react/blob/64ad60299d8c7d7534785c455694291b4c7aa427/lib/rules/no-unknown-property.js#L517):The name part doesn't seem right to me, and it's causing an error:
Actually I believe it's not really an issue in
eslint-plugin-react
, more like a bug ineslint-mdx
parser which gets exposed byeslint-plugin-react
's recent change. But I could be wrong since it's beyond my expertise :)