-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test-types
script back
#1622
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mdx/mdx/7hs49bFavYZ2hSVmppEU6waYoESw |
@@ -28,8 +28,8 @@ | |||
"publish-next": "lerna publish --force-publish=\"*\" --pre-dist-tag next --preid next", | |||
"test-api": "lerna run test-api", | |||
"test-coverage": "lerna run test-coverage", | |||
"test-types": "lerna run test-types", | |||
"test": "yarn build && yarn lint && yarn test-coverage" | |||
"test-types": "lerna --concurrency 1 run test-types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concurrent dtslint invocations were trampling each other installing TypeScript versions ... At least I think that's what was happening here -- and here ... Perhaps here too ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds alright to me.
Thoughts on this approach @JounQin?
I'm not sure, personally I'd prefer something like But for multiple ts versions, However, I don't think targeting multiple ts versions are worth unless we're not going to always follow latest TypeScript. |
@JounQin I think most of this change applies equally to Can we land this, and roll back the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, whether to drop dtslint
can be discussed later, let's fix current issues first.
I ran into an issue with
test-types
which this PR solves by adding"types": []
->**/tsconfig.json
. If it was the issue withtest-types
, perhaps it can be restored -> the CI?#1179 temporarily moved
test-types
-> its owntypes.yml
workflow, suggesting it be moved back ->test
once it's running stably:types.yml
was subsequently eliminated in #1338.The issue I encountered was dtslint implicitly including and checking every
node_modules/@types
declaration:This PR solves that by adding
"types": []
->**/tsconfig.json
:This will still type check our explicit
node_modules/@types
dependencies, however it will no longer implicitly include everynode_modules/@types
declaration.