-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LittleFS and FatFS choice on drop-down #23
Conversation
Added zipped jar binary release
Added binaries in release section
Added FatFS,, mk...fs binaries and modified Update lib to work with all three filesystems through serial port and ota. |
Added checkup of partition scheme vs. chosen filesystem Typo error fixes and minor changes
Modified README
…sv file lines. Minor changes in make.win batch file
containing 0x 0X hexadecimal or M,m,K,k bytes as described in https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/partition-tables.html#offset-size Similarily to gen_esp32part.py
…ompress.zip variant
This either needs to be merged, or forked into its own project, as there are a number of issues being reported that won't apply to @me-no-dev's version. |
@lbernstone Otherwise, I don't know what to do with merging to the original. It looks like it is mergeable. I guess the merge itself can be done only by the authorized people? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added LittleFS and FFat choices as well as "erase all" choices to the original SPIFFS tool.
Also if partitions.csv is present at sketch folder it will be used instead of IDE selection.
Can you separate out the bits that are absolutely needed to support the esp32s2 and submit those as a separate PR? That is what really needs to make it back upstream. |
@lbernstone |
Changed sysExec() to be based on: https://www.infoworld.com/article/2071275/when-runtime-exec---won-t.html The original way hangs on long uploading.
Changed line beginnings of transferred OUTPUT and ERROR from exec to console to look clieaner
Agree with @lbernstone for more conservative PR approach with fewer changes at a time, starting by most important ones. |
If you ever want to have this hack to add LittleFS and FatFS choice to the original tool made only for SPIFFS ... please consider this PR