Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simple match extend #183

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Implement simple match extend #183

merged 5 commits into from
Oct 1, 2024

Conversation

adraismawur
Copy link
Collaborator

This implements the simple match extend function, which ignores the idea of mismatching and should be much easier to explain than the legacy extend.

nlouwen
nlouwen requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@nlouwen nlouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic is sound, some indexing discrepancies if I am not mistaken. Also needs a merge from dev to add simple_match to the new EXTEND_STRATEGY enum, so mac can multiprocess

big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
big_scape/comparison/extend.py Outdated Show resolved Hide resolved
test/comparison/test_extend.py Outdated Show resolved Hide resolved
test/comparison/test_extend.py Outdated Show resolved Hide resolved
test/comparison/test_extend.py Show resolved Hide resolved
@adraismawur
Copy link
Collaborator Author

Excellent. As usual, working with the coordinates and the cds/domain distinction is not my strong suit.

@adraismawur adraismawur requested a review from nlouwen October 1, 2024 08:25
nlouwen
nlouwen approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@nlouwen nlouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adraismawur adraismawur merged commit 6a07618 into dev Oct 1, 2024
7 checks passed
@adraismawur adraismawur deleted the feature/match-extend branch October 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlouwen nlouwen nlouwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adraismawur @nlouwen