Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to force save the database to disk #190

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

adraismawur
Copy link
Collaborator

This adds a flag to the save_to_disk call that overrides the no-db-dump option. In terms of control flow, separation of concerns and general code this isn't great, but it is fast and effective.

@adraismawur adraismawur requested a review from nlouwen October 8, 2024 08:04
@adraismawur adraismawur self-assigned this Oct 8, 2024
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adraismawur adraismawur merged commit 205b485 into dev Oct 10, 2024
4 checks passed
@adraismawur adraismawur deleted the hotifx/dump-db-at-end branch October 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants