Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/partial task #201

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Hotfix/partial task #201

merged 3 commits into from
Nov 1, 2024

Conversation

nlouwen
Copy link
Collaborator

@nlouwen nlouwen commented Oct 25, 2024

Updates outdated partial_task logic:

  • no longer try to check if all distances are present before distance calculations (-> we already do this during distance calculation)
  • removes unused code+tests
  • some slight updates to logging info etc.

Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few tiny updates to doc and style (though ignore if irrelevant), otherwise lgtm

@adraismawur adraismawur self-assigned this Nov 1, 2024
@adraismawur adraismawur merged commit 60a1115 into dev Nov 1, 2024
4 checks passed
@nlouwen nlouwen deleted the hotfix/partial-task branch November 1, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants