Revert location of config yml file until a default/override config system is in place #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatarinaCarolina
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the config.yml back into the big_scape folder. This makes it harder for users to find but should be temporary until we get a better system.
The way we are currently using the configuration is a bit rigid - you either supply it with all of the values that the config as or you don't provide one. We should move to a default/override structure where A user can provide a partial set of configuration items which will be overridden, and the rest are inferred from default.
This way we can supply a default_config.yml with a bunch of explanations in the root of the directory, and we can keep a default config with all default values.
This also adds a few edits to the pyproject.toml which I think make it more robust in terms of pathing. Not sure. It seemed to help 🤷♂️