Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/benchmark figs #206

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Hotfix/benchmark figs #206

merged 5 commits into from
Nov 8, 2024

Conversation

nlouwen
Copy link
Collaborator

@nlouwen nlouwen commented Nov 7, 2024

Couple small benchmark details:

  • add correct tool name to benchmark figure axis
  • read the updated BS2 output correctly
  • update some test data

other:

  • classify category default
  • only stop a run based on changed config if a config hash is actually present (QOL for reuse of databases)

CatarinaCarolina
CatarinaCarolina approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nlouwen nlouwen merged commit f31e784 into dev Nov 8, 2024
4 checks passed
@nlouwen nlouwen deleted the hotfix/benchmark-figs branch November 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatarinaCarolina CatarinaCarolina CatarinaCarolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlouwen @CatarinaCarolina