Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli args #211

Merged
merged 9 commits into from
Nov 26, 2024
Merged

cli args #211

merged 9 commits into from
Nov 26, 2024

Conversation

CatarinaCarolina
Copy link
Collaborator

small changes to cli arg help messages, and let benchmark account for labels in run names

Copy link
Collaborator

@nlouwen nlouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only thing missing are corrections of arg names in cli_validations error logging, many still log with underscores

big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
big_scape/cli/cli_common_options.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nlouwen nlouwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CatarinaCarolina CatarinaCarolina merged commit 92daf1f into dev Nov 26, 2024
4 checks passed
@CatarinaCarolina CatarinaCarolina deleted the hotfix/benchmark-label branch November 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants