Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear central on new longest lcs #219

Merged
merged 5 commits into from
Dec 5, 2024
Merged

clear central on new longest lcs #219

merged 5 commits into from
Dec 5, 2024

Conversation

nlouwen
Copy link
Collaborator

@nlouwen nlouwen commented Dec 3, 2024

Clear central LCS list when encountering a new longest LCS. Prevents choosing the wrong LCS when there are multiple longest LCS with the same distance to the middle, along with a shorter LCS with the same distance to the middle.

Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

big_scape/comparison/lcs.py Show resolved Hide resolved
big_scape/comparison/lcs.py Outdated Show resolved Hide resolved
@nlouwen nlouwen merged commit 7b7b637 into dev Dec 5, 2024
7 checks passed
@nlouwen nlouwen deleted the hotfix/central-lcs branch December 5, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants