Deduplicate wkis in mcq.StatementRefs #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a subtle issue with duplicate wkis in compound statements:
It is possible for a compound statement to include simple statements which refer to the same wki, which would be included multiple times in the list returned by
mcq.StatementRef
.As a result, the same statement would be mapped to the same wki multiple times in the Refs table.
This would create garbage in the db and have the unfortunate side effect of having the same statement appear multiple times in a query result set even when querying for a single wki.
The PR fixes this by constructing a set for compound statements, which deduplicates the wkis.
Measurements indicate no performance penalty for compound statement processing.
PS: Also added dedup for simple statements, to protect from faulty publishers who don't dedup their references.
Performance degradation for simple statements is also neglible.