[PARKED] RIP dir lookup #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I'm not sure we've definitively decided to do this, I can still see directories being useful for certain scenarios. |
|
Oh, we are not ditching directories altogether, and we still publish peer info when we register for non-dht clients to discover us. This just prunes the directory lookup in concat in favor of using the DHT. |
|
let's sleep on this one |
|
There are some arguments for keeping the dir lookup, at least for a while longer:
So let's keep it parked and revisit later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As planned when we originally introduced DHT lookups, we can now retire directory lookups in mcnode.