Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sitemap #572

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Add sitemap #572

merged 6 commits into from
Nov 10, 2023

Conversation

KyleMaas
Copy link
Contributor

Description

Adds a basic sitemap XML file for the site which can be used for crawling and indexing it.

Steps

Pre-deploy

Post-deploy

@mgogoulos
Copy link
Contributor

This should not be enabled by default, since the database queries on files/views.py could be very problematic for large portals - eg hosting 10k's of media or more. For smaller installations that could be fine

May I suggest you add two things here:

  1. a setting on settings.py (eg GENERATE_SITEMAP) that defaults to False, and based on it the sitemap function on files/views.py either returns False or does the work
  2. add an entry on docs/ probably on the admin document, on how to enable sitemap?

Thanks

@KyleMaas
Copy link
Contributor Author

Sure, I could do that.

@KyleMaas
Copy link
Contributor Author

That work?

@mgogoulos mgogoulos merged commit 92c0ff5 into mediacms-io:main Nov 10, 2023
3 checks passed
@KyleMaas
Copy link
Contributor Author

Thanks!

@KyleMaas KyleMaas deleted the sitemap branch November 12, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants