Chromium Web Browser Support #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert this change - Chromium absolutely has MP4, mp3 support, at least in Ubuntu (where Chromium is quite popular). Test case - open a site running WP 4.0 RC, in Ubuntu's Chromium. No audio/video except ogg will play. |
|
There has been discussion on a ticket for Wordpress where this was brought up - WP uses a patched version that doesn't have an exception the breaks Chromium: https://core.trac.wordpress.org/ticket/29110 Can we please have this added to the base MeJS as well? |
ale-grosselle
pushed a commit
to ale-grosselle/mediaelement
that referenced
this pull request
Nov 25, 2016
Chromium Web Browser Support
|
Still not fixed in the version in latest Wordpress... any eta on when this can be removed? |
|
I added a section to use the latest version of the plugin with Wordpress while this happens. I haven't had an answer about this issue yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to git/github, so hope what I'm doing is right...
This adds detection for the Chromium web browser, which only contains open-source video codecs (i.e. WebM and Theora). Unlike Chrome, it has no native support for MP4 files.
This is also related to a 3 year old (unresolved) issue, "Chrome vs Chromium video source confusion" #62.
Feel free to improve the code, as I'm not much of the "programmer type".