Use an event to notify features of controls size change #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking the prototype for various methods that features add, an event should be triggered on the player container that signals when the controls have been sized.
Use the `controlsresize` event to change the progress and current rail.
This seems to be a good workaround to the issue of the volume handle not being rendered in the right location if media is not visible when the player is built.
This will help correct poor sizing when a player is invisible when it's built.
|
Great changes! |
johndyer
added a commit
that referenced
this pull request
Jul 31, 2015
Use an event to notify features of controls size change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow new features that may need to know when the controls are sized so they can respond in turn. It also allows existing features to hook into the player's API for
setControlsSizeinstead of that function looking at the prototype for specific feature added functions.