3.x dev support multiple tracks with same language code #1957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a couple oddities/bugs surrounding the assumption that a video will only have one track per language. I didn't file Issue reports, but I can if that's also desirable. Having two or more tracks of the same language produces the following bugs:
produces this broken UI:
Per the example below from in the HTML5 spec, I believe these changes in this PR result in a more-correct handling of track elements, as it appears to be acceptable to support multiple tracks of one language.
While I'm not positive these changes represent a perfect changeset for handling track elements, these changes definitely fix bugs in a common use case: multiple tracks of the same language.