Skip to content

Commit

Permalink
Review PR
Browse files Browse the repository at this point in the history
  • Loading branch information
@nflaig
nflaig committed Jun 27, 2024
1 parent 79c54ae commit 6bc0ec8
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 14 deletions.
12 changes: 6 additions & 6 deletions CHANGES.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ There are likely to be descriptions etc outside of the list below, but new query

| Endpoint | [Lighthouse](https://github.com/sigp/lighthouse) | [Lodestar](https://github.com/ChainSafe/lodestar) | [Nimbus](https://github.com/status-im/nimbus-eth2) | [Prysm](https://github.com/prysmaticlabs/prysm) | [Teku](https://github.com/ConsenSys/teku) |
|---------------------------------------------------------------------------------------------------------------------|--------------------------------------------------|---------------------------------------------------|----------------------------------------------------|-------------------------------------------------|-------------------------------------------|
| [#447](https://github.com/ethereum/beacon-APIs/pull/447) `GET /eth/v2/validator/aggregate_attestation` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/blocks/{block_id}/attestations` added | | - | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/pool/attestations` added | | - | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `POST /eth/v2/beacon/pool/attestations` added | | - | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/pool/attester_slashings` added | | - | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `POST /eth/v2/beacon/pool/attester_slashings` added | | - | | | |
| [#447](https://github.com/ethereum/beacon-APIs/pull/447) `GET /eth/v2/validator/aggregate_attestation` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/blocks/{block_id}/attestations` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/pool/attestations` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `POST /eth/v2/beacon/pool/attestations` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `GET /eth/v2/beacon/pool/attester_slashings` added | | | | | |
| [#448](https://github.com/ethereum/beacon-APIs/pull/448) `POST /eth/v2/beacon/pool/attester_slashings` added | | | | | |


The Following are no longer in the Standard API, removed since the latest version.
Expand Down
2 changes: 1 addition & 1 deletion apis/beacon/pool/attester_slashings.v2.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ get:
properties:
version:
type: string
enum: [ phase0, altair, bellatrix, capella, deneb, electra ]
enum: [phase0, altair, bellatrix, capella, deneb, electra]
example: "phase0"
data:
anyOf:
Expand Down
2 changes: 1 addition & 1 deletion types/attestation.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ PendingAttestation:
inclusion_delay:
$ref: "./primitive.yaml#/Uint64"
proposer_index:
$ref: "./primitive.yaml#/Uint64"
$ref: "./primitive.yaml#/Uint64"
1 change: 0 additions & 1 deletion types/attestation_data.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ AttestationData:
$ref: "./misc.yaml#/Checkpoint"
target:
$ref: "./misc.yaml#/Checkpoint"

8 changes: 4 additions & 4 deletions types/electra/attestation.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ Electra:
description: "Attesting validator indices"
items:
$ref: "../primitive.yaml#/Uint64"
data:
$ref: '../attestation_data.yaml#/AttestationData'
signature:
$ref: '../primitive.yaml#/Signature'
description: "The BLS signature of the `IndexedAttestation`, created by the validator of the attestation."
data:
$ref: '../attestation_data.yaml#/AttestationData'

Attestation:
type: object
Expand All @@ -25,9 +25,9 @@ Electra:
$ref: "../primitive.yaml#/BitList"
description: "Attester aggregation bits."
data:
$ref: '../attestation_data.yaml#/AttestationData'
$ref: "../attestation_data.yaml#/AttestationData"
signature:
$ref: '../primitive.yaml#/Signature'
$ref: "../primitive.yaml#/Signature"
description: "BLS aggregate signature."
committee_bits:
$ref: "../primitive.yaml#/Bitvector"
Expand Down
2 changes: 1 addition & 1 deletion types/electra/attester_slashing.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Electra:
AttesterSlashing:
type: object
description: "The [`AttesterSlashing`](https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.2/specs/electra/beacon-chain.md#attesterslashing) object from the CL spec."
description: "The [`AttesterSlashing`](https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.3/specs/electra/beacon-chain.md#attesterslashing) object from the CL spec."
required: [attestation_1, attestation_2]
properties:
attestation_1:
Expand Down

0 comments on commit 6bc0ec8

Please sign in to comment.