-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add allow list to tokenizer #148
Conversation
…abia into allowlisttokenizer
This message is sent automatically Hello @yenwel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yenwel!
I requested some changes, and they are not always easy because there are some lifetimes issues. Don't hesitate to ask if you need help! 😄
Co-authored-by: Many the fish <[email protected]>
Co-authored-by: Many the fish <[email protected]>
Co-authored-by: Many the fish <[email protected]>
Co-authored-by: Many the fish <[email protected]>
Co-authored-by: Many the fish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll investigate this move
tomorrow! But I think we can merge your PR keeping it. 🤔
Co-authored-by: Many the fish <[email protected]>
Co-authored-by: Many the fish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I let bors run the tests, then if everything passes, your PR will be merged automatically.
Thank you for your contribution despite its difficulty!
bors merge
Build succeeded:
|
This message is sent automatically Thank you for contributing to Meilisearch. If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form. |
Pull Request
Related issue
Fixes #132
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: