Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.28: _geo accepts string values #1694

Closed
guimachiavelli opened this issue Jun 7, 2022 · 0 comments · Fixed by #1707 or #1735
Closed

v0.28: _geo accepts string values #1694

guimachiavelli opened this issue Jun 7, 2022 · 0 comments · Fixed by #1707 or #1735
Assignees
@guimachiavelli
Milestone
v0.28

Comments

@guimachiavelli
Copy link
Member

guimachiavelli commented Jun 7, 2022 •
edited
Loading

Starting with v0.28, _geo fields (both lat and lng) should accept numbers in both numeric and string formats:

"_geo": {
  "lat": 0.0, // floating point number, valid
  "lng": "0.0" // a string that can be adequately converted into a float, also valid
}

We need to update the Geosearch guide so this is stated clearly.

References

Spec: meilisearch/specifications#83
Issue on core: meilisearch/meilisearch#2354
SME: @irevoire
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 7, 2022
@guimachiavelli guimachiavelli self-assigned this Jun 9, 2022
@guimachiavelli guimachiavelli mentioned this issue Jun 15, 2022
Merged
@guimachiavelli guimachiavelli linked a pull request Jun 15, 2022 that will close this issue
v0.28 #1707
Merged
@guimachiavelli guimachiavelli mentioned this issue Jun 16, 2022
Merged
bors bot added a commit that referenced this issue Jun 29, 2022
@bors @guimachiavelli
Merge #1735
13459d7 
1735: v0.28: accepted `_geo` `lat`, `lng` types r=maryamsulemani97 a=guimachiavelli

Closes #1694

Co-authored-by: gui machiavelli <[email protected]>
bors bot added a commit that referenced this issue Jul 11, 2022
@bors @guimachiavelli
@dichotommy @maryamsulemani97
Merge #1707
00cb6df 
1707: v0.28 r=guimachiavelli a=guimachiavelli

This is a staging PR for all changes related to Meilisearch v0.28.

Please avoid making changes directly to this PR; instead, create new child branches based off this one.

Closes #1687, #1688, #1691, #1692, #1693, #1694, #1699, #1700, #1701, #1702, #1703, #1704, #1706, #1722, #1727, #561

Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Tommy Melvin <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
@bors bors bot closed this as completed in #1707 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guimachiavelli guimachiavelli

Labels
None yet
Projects
None yet
Milestone
v0.28
Development

Successfully merging a pull request may close this issue.

v0.28 meilisearch/documentation
v0.28: accepted _geo lat, lng types meilisearch/documentation
1 participant
@guimachiavelli