-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to configure new prefixSearch
and facetSearch
index settings
#702
Conversation
Hey @norkunas 👋 I went ahead I tagged you as a reviewer since you helped me with the previous PRs. I hope you can assist me with reviewing this one too. 🙏 |
// Settings - Facet Search | ||
|
||
/** | ||
* @since Meilisearch v1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need this annotation (everywhere)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say we need it to the point where we should update all the code base. But if it shows up in the generated documentation, then it's useful information for the reader. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
prefixSearch
and facetSearch
index settingsprefixSearch
and facetSearch
index settings
692: Changes related to the next Meilisearch release (v1.12.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#307 This PR: - gathers the changes related to the next Meilisearch release (v1.12.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.12.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.12.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ 705: Update version for the next release (v1.12.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-php to a new version: "v1.12.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #699 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. A batch is a set of tasks processed together. - **Addition:** #698 The `TaskQuery` class now has a `setReverse()` method to retrieve tasks in reverse chronological order. ```php client->getTasks((new TasksQuery())->setReverse(true)); ``` - **Addition:** #702 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```php // disable prefix search $index->updatePrefixSearch('disabled'); // reset prefix search settings $index->resetPrefixSearch(); // disable facet search $index->updateFacetSearch(false); // reset facet search settings $index->resetFacetSearch(); ``` ## 🐛 Bug Fixes - fix: pull the latest in the CI instead of forcing the v1.11 (#691) `@/mdubus` - Make `hitsCount` always the number of `hits` (and not `totalHits` value) (#701) `@/johnnynotsolucky` ## ⚙️ Maintenance/misc - Update CI to run with PHP 8.4 (#696) `@/norkunas` - Fixed SearchNestedFieldsTest test (#704) `@/aivchen` - PHPStan 2 + fixed uninitialized properties in SearchResult (#706) `@/aivchen` Thanks again to `@/aivchen,` `@/johnnynotsolucky,` `@/mdubus,` `@/norkunas,` Andrei Ivchenkov, and `@/Strift!` 🎉 Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine <[email protected]> Co-authored-by: Strift <[email protected]> Co-authored-by: Laurent Cazanove <[email protected]>
705: Update version for the next release (v1.12.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-php to a new version: "v1.12.0" CHANGELOGS 👇 This version introduces features released on Meilisearch v1.12.0 🎉 Check out the [Meilisearch v1.12.0 changelog](https://github.com/meilisearch/meilisearch/releases/tag/v1.12.0) for more information. ## 🚀 Enhancements - **Addition:** #699 Introducing new methods to get one or several batches, respectively `getBatch()` and `getBatches()`. A batch is a set of tasks processed together. - **Addition:** #698 The `TaskQuery` class now has a `setReverse()` method to retrieve tasks in reverse chronological order. ```php client->getTasks((new TasksQuery())->setReverse(true)); ``` - **Addition:** #702 Index settings now allow disabling **prefix search** and **facet search**. They're both enabled by default. The SDK now comes with dedicated methods to configure these settings. ```php // disable prefix search $index->updatePrefixSearch('disabled'); // reset prefix search settings $index->resetPrefixSearch(); // disable facet search $index->updateFacetSearch(false); // reset facet search settings $index->resetFacetSearch(); ``` ## 🐛 Bug Fixes - fix: pull the latest in the CI instead of forcing the v1.11 (#691) `@/mdubus` - Make `hitsCount` always the number of `hits` (and not `totalHits` value) (#701) `@/johnnynotsolucky` ## ⚙️ Maintenance/misc - Update CI to run with PHP 8.4 (#696) `@/norkunas` - Fixed SearchNestedFieldsTest test (#704) `@/aivchen` - PHPStan 2 + fixed uninitialized properties in SearchResult (#706) `@/aivchen` Thanks again to `@/aivchen,` `@/johnnynotsolucky,` `@/mdubus,` `@/norkunas,` Andrei Ivchenkov, and `@/Strift!` 🎉 Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine <[email protected]>
Pull Request
Related issue
Fixes #694
What does this PR do?
getSettings()
, andupdateSettings
allow the new settingsgetFacetSearch()
,updateFacetSearch()
, andresetFacetSearch()
methodsgetPrefixSearch()
,updatePrefixSearch()
, andresetPrefixSearch()
methods