Fix the New Indexer Spilling #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
requested review from
ManyTheFish and
irevoire
and removed request for
ManyTheFish
ManyTheFish
force-pushed
the
fix-spilling
branch
from
1e0afbd to
25f79ac
Compare
Kerollmops
force-pushed
the
fix-spilling
branch
2 times, most recently
from
a1de25f to
248b4ae
Compare
when filtering on the cache to merge
Kerollmops
force-pushed
the
fix-spilling
branch
from
248b4ae to
acdd5aa
Compare
irevoire
approved these changes
Dec 12, 2024
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two bugs in the merging of the spilled caches. Thanks to @ManyTheFish and @irevoire 👏