Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete test code #5173

Conversation

K-Kumar-01
Copy link
Contributor

Pull Request

Removes the test from the meilisearch/search/mod.rs. The tests were already split in the PR #5171

What does this PR do?

  • Removes the obsolete tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@K-Kumar-01
Copy link
Contributor Author

@irevoire @curquiza
In PR #5171, I forgot to remove the tests from the original file. This PR removes the obsolete tests present in the mod.rs file.

Please review.

Signed-off-by: Kushal Kumar <[email protected]>
@K-Kumar-01 K-Kumar-01 changed the title refactor: remove obsolete test code Remove obsolete test code Dec 17, 2024
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yes I missed that my bad
bors merge

Copy link
Contributor

meili-bors bot commented Dec 18, 2024

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@irevoire irevoire added this to the v1.13.0 milestone Dec 18, 2024
@irevoire irevoire added the maintenance Issue about maintenance (CI, tests, refacto...) label Dec 18, 2024
@irevoire
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Dec 18, 2024

Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

meili-bors bot added a commit that referenced this pull request Dec 18, 2024
5173: Remove obsolete test code r=irevoire a=K-Kumar-01

# Pull Request
Removes the test from the meilisearch/search/mod.rs. The tests were already split in the PR #5171 


## What does this PR do?
- Removes the obsolete tests

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Kushal Kumar <[email protected]>
Copy link
Contributor

meili-bors bot commented Dec 18, 2024

Build failed:

@irevoire
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Dec 18, 2024

@meili-bors meili-bors bot merged commit fc4b7cc into meilisearch:main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants