Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Bump min supported elixir version to 1.8 #184

Merged
merged 1 commit into from
May 27, 2020
Merged

Bump min supported elixir version to 1.8 #184

merged 1 commit into from
May 27, 2020

Conversation

mkorszun
Copy link
Collaborator

  • Update consumer docs - remove spawn reference in the consumer concurrency mode
  • Drop support for elixir 1.7 - it is old enough
  • Test with OTP22 on travis as well

Description

Checklist

  • I have added unit tests to cover my changes.
  • I have improved the code quality of this repo. (refactoring, or reduced number of static analyser issues)
  • I have updated the documentation accordingly

* Update consumer docs - remove `spawn` reference in the consumer concurrency mode
* Drop support for `elixir 1.7` - it is old enough
* Test with `OTP22` on travis as well
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.333% when pulling 0ee66f6 on some-cleanup into bbe426b on master.

Copy link
Collaborator

@akoutmos akoutmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -63,8 +63,8 @@ defmodule GenRMQ.Consumer do
[recommended](https://www.rabbitmq.com/priority.html#resource-usage).

`concurrency` - defines if `handle_message` callback is called
in separate process using [spawn](https://hexdocs.pm/elixir/Process.html#spawn/2)
function. By default concurrency is enabled. To disable, set it to `false`
in separate process using [supervised task](https://hexdocs.pm/elixir/Task.Supervisor.html).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mkorszun mkorszun merged commit bc307d1 into master May 27, 2020
@mkorszun mkorszun deleted the some-cleanup branch May 27, 2020 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants