Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/expect emit new foundry version #203

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

philbow61
Copy link
Contributor

Description

The new foundry version changes the logic of how expect emits are evaluated. This caused old tests to fail.

Other changes

  • N/A

Tested

  • All tests are green again

Related issues

Backwards compatibility

Documentation

Copy link
Member

@bayological bayological left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🔥

Copy link
Collaborator

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nvtaveras nvtaveras merged commit e87d95e into develop Jun 8, 2023
@nvtaveras nvtaveras deleted the fix/expect-emit-new-foundry-version branch June 8, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor tests that use expectEmit cheatcode
3 participants