fix(removecalls): remove unsafe optimization

merceyz · Dec 23, 2019 · b0deb61 · b0deb61
1 parent 3e92ddb
commit b0deb61
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/src/visitors/removeUnnecessaryCalls.js b/src/visitors/removeUnnecessaryCalls.js
@@ -75,9 +75,6 @@ const transforms = [
           isSafeConditionalExpression(arg.right.right)))
     ) {
       return t.conditionalExpression(arg.left, arg.right, t.stringLiteral(''));
-    } else if (t.isLogicalExpression(arg, { operator: '||' }) && isStringLike(arg.right)) {
-      // Assume that arg.left returns a string value
-      return arg;
     }
   },
 

diff --git a/test/fixtures/remove-unnecessary-calls/single-logical-expression/code.js b/test/fixtures/remove-unnecessary-calls/single-logical-expression/code.js
@@ -1,4 +1,3 @@
 const foo = 'test';
 
 const x = clsx(foo && 'bar');
-const y = clsx(foo || 'bar');
diff --git a/test/fixtures/remove-unnecessary-calls/single-logical-expression/output.js b/test/fixtures/remove-unnecessary-calls/single-logical-expression/output.js
@@ -1,3 +1,2 @@
 const foo = 'test';
 const x = foo ? 'bar' : '';
-const y = foo || 'bar';