Fixed stderr warnings

[yakschuss]

Deflected when using RUBYOPT=-w rake 2>&1 1>/dev/null | grep merit | sort --unique

[houndci-bot]

Line is too long. [111/80]

[tute]

@yakschuss we are not passing an argument to instance_variable_defined?! Suggested rewrite:

def target_object
  variable_name = :"@#{controller_name.singularize}"
  if instance_variable_defined?(variable_name)
    target_obj = instance_variable_get(variable_name)
    if target_obj.nil?
      str = '[merit] No object found, you might need a ' \
        "'@#{controller_name.singularize}' variable in " \
        "'#{controller_path}_controller' if no reputation is applied. " \
        'If you are using `model_name` option in the rule this is ok.'
      Rails.logger.warn str
    end
  end
  target_obj
end

[tute]

Thar version can probably improved, or we might be able to extract another method off of it.

[tute]

Could we extract another method with this, so it reads something like:

warn_no_object_found if target_obj.nil?

[yakschuss]

    def target_object
      variable_name = :"@#{controller_name.singularize}"
      target_obj = instance_variable_get(variable_name) if instance_variable_defined?(variable_name)
      target_obj.nil? ? warn_no_object_found : target_obj
    end

should work, as instance_variable_get would return nil if variable_name is not defined, but the warnings came back with that method.

maybe solution committed works for you

[tute]

In the case where target_obj.nil? this new code returns true, because that's what Rails.logger.warn. It should instead return nil, either explicit or implicit (no else branch in the if).

[tute]

Looking better! Suggested rewrite, as per my comments:

def target_object
  variable_name = :"@#{controller_name.singularize}"
  if instance_variable_defined?(variable_name)
    if target_obj = instance_variable_get(variable_name)
      target_obj
    else
      warn_no_object_found
    end
  end
end

def warn_no_object_found
  str = '[merit] No object found, you might need a ' \
    "'@#{controller_name.singularize}' variable in " \
    "'#{controller_path}_controller' if no reputation is applied. " \
    'If you are using `model_name` option in the rule this is ok.'
  Rails.logger.warn str
  nil
end

[yakschuss]

@tute - Thanks for the advice! I definitely learned something.

[tute]

This is great! Can you please squash your commits together, add a meaningful commit message linking to the original issue, and push? Then I'll merge. Thank you! :)

[tute]

Thank you! :) 👏