fix the build - would loop forever if there were no files to send (#4188

)
meshtastic · Jun 28, 2024 · 41d633b · 41d633b
1 parent 2cb6e7b
commit 41d633b
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/mesh/PhoneAPI.cpp b/src/mesh/PhoneAPI.cpp
@@ -354,15 +354,14 @@ size_t PhoneAPI::getFromRadio(uint8_t *buf)
 
     case STATE_SEND_FILEMANIFEST: {
         LOG_INFO("getFromRadio=STATE_SEND_FILEMANIFEST\n");
-        fromRadioScratch.which_payload_variant = meshtastic_FromRadio_fileInfo_tag;
-        if (config_state < filesManifest.size()) {
+        // last element
+        if (config_state == filesManifest.size()) { // also handles an empty filesManifest
+            state = STATE_SEND_COMPLETE_ID;
+            config_state = 0;
+        } else {
+            fromRadioScratch.which_payload_variant = meshtastic_FromRadio_fileInfo_tag;
             fromRadioScratch.fileInfo = filesManifest.at(config_state);
             config_state++;
-            // last element
-            if (config_state == filesManifest.size()) {
-                state = STATE_SEND_COMPLETE_ID;
-                config_state = 0;
-            }
         }
         break;
     }