Merge branch 'master' into fix-SHT31

meshtastic · Mar 11, 2024 · 9ac0830 · 9ac0830
2 parents 6e72722 + e16689a
commit 9ac0830
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/mesh/ReliableRouter.cpp b/src/mesh/ReliableRouter.cpp
@@ -167,8 +167,6 @@ bool ReliableRouter::stopRetransmission(GlobalPacketId key)
     auto old = findPendingPacket(key);
     if (old) {
         auto p = old->packet;
-        auto numErased = pending.erase(key);
-        assert(numErased == 1);
         /* Only when we already transmitted a packet via LoRa, we will cancel the packet in the Tx queue
           to avoid canceling a transmission if it was ACKed super fast via MQTT */
         if (old->numRetransmissions < NUM_RETRANSMISSIONS - 1) {
@@ -177,6 +175,8 @@ bool ReliableRouter::stopRetransmission(GlobalPacketId key)
             // now free the pooled copy for retransmission too
             packetPool.release(p);
         }
+        auto numErased = pending.erase(key);
+        assert(numErased == 1);
         return true;
     } else
         return false;