Skip favorite nodes when clearing out oldest in NodeDB (#3464)

* Skip favorite nodes when clearing out oldest in NodeDB * We should actually map between the types
meshtastic · Mar 24, 2024 · ae32c24 · ae32c24
1 parent 753fc78
commit ae32c24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/mesh/NodeDB.cpp b/src/mesh/NodeDB.cpp
@@ -939,7 +939,7 @@ meshtastic_NodeInfoLite *NodeDB::getOrCreateMeshNode(NodeNum n)
             uint32_t oldest = UINT32_MAX;
             int oldestIndex = -1;
             for (int i = 1; i < numMeshNodes; i++) {
-                if (meshNodes->at(i).last_heard < oldest) {
+                if (!meshNodes->at(i).is_favorite && meshNodes->at(i).last_heard < oldest) {
                     oldest = meshNodes->at(i).last_heard;
                     oldestIndex = i;
                 }

diff --git a/src/mesh/TypeConversions.cpp b/src/mesh/TypeConversions.cpp
@@ -12,6 +12,7 @@ meshtastic_NodeInfo TypeConversions::ConvertToNodeInfo(const meshtastic_NodeInfo
     info.channel = lite->channel;
     info.via_mqtt = lite->via_mqtt;
     info.hops_away = lite->hops_away;
+    info.is_favorite = lite->is_favorite;
 
     if (lite->has_position) {
         info.has_position = true;