Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Heap-Leak in DeviceTelemetryModule #2239

Closed
karamo opened this issue Feb 1, 2023 · 2 comments
Closed

[Bug]: Heap-Leak in DeviceTelemetryModule #2239

karamo opened this issue Feb 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@karamo
Copy link

karamo commented Feb 1, 2023

Category

Firmware

Hardware

T-Beam, Other

Firmware Version

2.0.17

Description

As shown in issue #2238, no heap leaks occur with role REPEATER. In subsequent test runs, the effects are tested individually. The difference between CLIENT and REPEATER are the following threads, which do not run at role REPEATER:
• GPS
• NodeInfoModule
• PositionModule
• DeviceTelemetryModule

Issue_8
GPS, NodeInfoModule, PositionModule = no Heap-Leak

Issue_9
(red) TEST = CLIENT
(magenta) ZELX = CLIENT (magenta) TLORA (Referenz)
(blue) WZ1 = REPEATER + DeviceTelemetryModule

A heap-leak occurs when the DeviceTelemetryModule is active.

@karamo karamo added the bug Something isn't working label Feb 1, 2023
@karamo
Copy link
Author

karamo commented Feb 2, 2023

I found the heap-leak. @caveman99 will make the PR.
Issue_2239
blue = REPEATER
red = CLIENT
magenta = control node with unmodified 2.0.17

@mc-hamster
Copy link
Member

WOW, WOW, WOW!!!!!

Thank you for this great research!

caveman99 added a commit that referenced this issue Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants