Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Allow the root MQTT topic msh to be user-configurable #2380

Closed
ghostop14 opened this issue Mar 24, 2023 · 3 comments
Closed

[Feature Request]: Allow the root MQTT topic msh to be user-configurable #2380

ghostop14 opened this issue Mar 24, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed requires-protos A change in device that requires changes to protobufs

Comments

@ghostop14
Copy link
Contributor

Platform

NRF52, ESP32

Description

Planning ahead for scalability, if the root topic currently hard-coded at msh could be user changable, a single MQTT broker could apply user acls to completely separated meshes on the same box for multi-mesh isolation and scalability. Something like mqtt.mesh_root (default = msh).
@ghostop14 ghostop14 added the enhancement New feature or request label Mar 24, 2023
@caveman99 caveman99 added help wanted Extra attention is needed good first issue Good for newcomers requires-protos A change in device that requires changes to protobufs labels Mar 30, 2023
caveman99 added a commit to meshtastic/protobufs that referenced this issue Apr 7, 2023
@caveman99
support configurable topic root meshtastic/firmware#2380
ee46f58
@caveman99 caveman99 mentioned this issue Apr 7, 2023
Merged
caveman99 added a commit that referenced this issue Apr 7, 2023
@caveman99
Implement #2380
0482d0e
thebentern pushed a commit that referenced this issue Apr 7, 2023
@caveman99
Implement #2380 (#2418)
43cff7a
@caveman99
Copy link
Member

@ghostop14 can you test this?

@ghostop14
Copy link
Contributor Author

Sure thing. I'll have some time tonight.

@ghostop14
Copy link
Contributor Author

Tested. Looks good. Worked perfectly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed requires-protos A change in device that requires changes to protobufs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caveman99 @thebentern @ghostop14