Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NimBLE: less debugging data, no more constant stream of BLE hex logging #1062

Merged
merged 8 commits into from
Jan 5, 2022

Conversation

linagee
Copy link
Contributor

@linagee linagee commented Jan 5, 2022

Originally requested by @mc-hamster

.pio/libdeps/tbeam/NimBLE-Arduino/src/esp_nimble_cfg.h and .pio/libdeps/tbeam/NimBLE-Arduino/src/syscfg/syscfg.h were providing the default previously. (The default was 1 or LOG_LEVEL_INFO.)

Possible log levels are listed in .pio/libdeps/tbeam/NimBLE-Arduino/src/log_common/log_common.h

This should get rid of:
ble_sm_alg_s1() and messages like that providing unnecessary debug low-level BLE data.

linagee and others added 7 commits December 29, 2021 19:57
esp_nimble_cfg.h and syscfg/syscfg.h were providing the default
previously.
This should get rid of:
ble_sm_alg_s1() and messages like that proving low-level BLE data.
@linagee linagee changed the title NimBLE: less debugging data, no more constant stream of hex NimBLE: less debugging data, no more constant stream of BLE hex logging Jan 5, 2022
Copy link
Member

@mc-hamster mc-hamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to the ini describing the change and the effect of the change.

This way if someone needs more output, they know how to get it.

@linagee linagee requested a review from mc-hamster January 5, 2022 01:59
@mc-hamster mc-hamster merged commit e9f01de into meshtastic:master Jan 5, 2022
@mc-hamster
Copy link
Member

thanks!

linagee added a commit to linagee/Meshtastic-device that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants