-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canned message plugin #1090
Canned message plugin #1090
Conversation
@prampec I see meshplugin was updated to trigger a screen change. If that's the case, please consider doing that from within CannedMessagePlugin.cpp/h. This crosses the streams just a little bit. |
@mc-hamster Can you please explain what "crosses the streams"?! Now Screen relies on MeshPlugin is this your concern? (Further more, there are some lines marked with TODO-s. Please inspect those lines with care!) |
Sorry for the movie reference. Yes, why is MeshPlugin needed in screen? |
Movie? Okay, learned something today. :) It is all about the UIFrameEvent type. We can also do it in the other way round: define UIFrameEvent in Screen.h and reference Screen.h in MeshPlugin. What do you think? |
Got it. Thanks! |
Plugin to feature sending predefined texts from the device without having to use the phone app.
An InputBroker is introduced, so plugins require input can be independent from the input hardware.
Screen and MeshPlugin is altered, so plugins can report screen update requests to Screen class.