Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canned message plugin #1090

Merged
merged 20 commits into from
Jan 15, 2022
Merged

Conversation

prampec
Copy link
Contributor

@prampec prampec commented Jan 13, 2022

Plugin to feature sending predefined texts from the device without having to use the phone app.

An InputBroker is introduced, so plugins require input can be independent from the input hardware.

Screen and MeshPlugin is altered, so plugins can report screen update requests to Screen class.

@mc-hamster
Copy link
Member

@prampec I see meshplugin was updated to trigger a screen change.

If that's the case, please consider doing that from within CannedMessagePlugin.cpp/h. This crosses the streams just a little bit.

@prampec
Copy link
Contributor Author

prampec commented Jan 14, 2022

@mc-hamster Can you please explain what "crosses the streams"?! Now Screen relies on MeshPlugin is this your concern?

(Further more, there are some lines marked with TODO-s. Please inspect those lines with care!)

@mc-hamster
Copy link
Member

@mc-hamster Can you please explain what "crosses the streams"?! Now Screen relies on MeshPlugin is this your concern?

(Further more, there are some lines marked with TODO-s. Please inspect those lines with care!)

Sorry for the movie reference.

Yes, why is MeshPlugin needed in screen?

@prampec
Copy link
Contributor Author

prampec commented Jan 15, 2022

Movie? Okay, learned something today. :)

It is all about the UIFrameEvent type. We can also do it in the other way round: define UIFrameEvent in Screen.h and reference Screen.h in MeshPlugin. What do you think?

@mc-hamster mc-hamster merged commit a9ed26f into meshtastic:master Jan 15, 2022
@mc-hamster
Copy link
Member

Got it. Thanks!

@prampec prampec deleted the CannedMessagePlugin branch January 19, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants