Don't send me to null island, please #1576
Conversation
🤖 Pull request artifacts
|
src/modules/PositionModule.cpp
Outdated
|
|
||
| sendOurPosition(NODENUM_BROADCAST, requestReplies); | ||
| } | ||
| } else { | ||
| DEBUG_MSG("Channel utilization is >50 percent. Skipping this opportunity to send.\n"); |
There was a problem hiding this comment.
Completely unrelated to the PR, why does it say 50% down here when it's 40% up there?
There was a problem hiding this comment.
lol, that's a nice misleading typo
There was a problem hiding this comment.
Typo fix made it into the merge :-)
Garth was reporting zeros on non-smart broadcast position packets, but I think that was for mostly for non T-Echo devices. I'm gonna add this guard for now just to be consistent, since we have the same on smart broadcast. |
|
I haven't seen the specific T-Echo problems since i swapped out the math in TinyGPS. Fingers crossed. Just adding the note to keep your eyes peeled if this is happening again. |
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-1-3-29-public-preview/6241/1 |
@garthvh I think this should fix the null island brigade