-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variant of sx1268 with t-echo added #1654
Conversation
Does this actually require a board variant. What's preventing it from working with the existing definition? |
The code is written in a way you can define both chips and have it use the once present. see https://github.com/meshtastic/Meshtastic-device/blob/fd27a40edb941366a212204731c062a7ac90d48a/src/main.cpp#L352-L376 - there may be the need to add additional runtime flags, cause these macros are used in a few other places. Definitely no need for a separate variant though. |
Yes, creating a new variant is not the best choice, maybe it should be determined at runtime which module it is |
@lewisxhe it's pretty much the same on the T-Beam Firmware, it auto detects the radio too. I can assist in a new pull requests to add this as an unified firmware, if required :-) |
There is no search for the radio model in the code. Using the SX1268 in the actual test will display Critical fault #3 on the screen. The following is the complete startup log
|
If possible, add auto-find radio model to match different variants [1262/1268] |
LilyGo techo plans to launch the 433 version of the sx1268 variant, I added the sx1268 option according to the project situation, other hardware remains unchanged, only changed the 433 version to SX1268