Fix checking channel name

[GUVWAF]

In order to check whether an incoming packet arrived at the correct channel, amongst others the channel name was compared with the 'boundChannel' of the module. This was done using strcmp, which returns zero if strings are equal. In this commit this was changed to checking for 'true'.

With this PR it checks for zero again, so e.g. an Admin packet on the primary channel is not allowed anymore:

07:06:24 52 [RadioIf] Lora RX (id=0x543c64b5 Fr0xe4 To0x34, WantAck1, HopLim3 Ch0x8 encrypted rxSNR=12.75 rxRSSI=1.84101)
07:06:24 52 [RadioIf] AirTime - Packet received : 649ms
07:06:24 52 [Router] Add packet record (id=0x543c64b5 Fr0xe4 To0x34, WantAck1, HopLim3 Ch0x8 encrypted rxSNR=12.75 rxRSSI=1.84101)
07:06:24 52 [Router] Using channel 0 (hash 0x8)
07:06:24 52 [Router] Expanding short PSK #1
07:06:24 52 [Router] Using AES128 key!
07:06:24 52 [Router] ESP32 crypt fr=bff18ce4, num=543c64b5, numBytes=8!
07:06:24 52 [Router] decoded message (id=0x543c64b5 Fr0xe4 To0x34, WantAck1, HopLim3 Ch0x0 Portnum=6 WANTRESP rxtime=1664607984 rxSNR=12.75 rxRSSI=1.84101)
07:06:24 52 [Router] handleReceived(REMOTE) (id=0x543c64b5 Fr0xe4 To0x34, WantAck1, HopLim3 Ch0x0 Portnum=6 WANTRESP rxtime=1664607984 rxSNR=12.75 rxRSSI=1.84101)
07:06:24 52 [Router] Module 'Admin' wantsPacket=1
07:06:24 52 [Router] packet on wrong channel, returning error (id=0x543c64b5 Fr0xe4 To0x34, WantAck1, HopLim3 Ch0x0 Portnum=6 WANTRESP rxtime=1664607984 rxSNR=12.75 rxRSSI=1.84101)
07:06:24 52 [Router] Alloc an err=33,to=0xbff18ce4,idFrom=0x543c64b5,id=0x1b93d200

[github-actions]

🤖 Pull request artifacts

file	commit
pr1736-firmware-1.3.42.3669cf7.zip	3669cf7

[thebentern]

Great fix!

[andrekir]

looks great, thank you!