Making meshtastic-dr-dev E22-900M22S/M30S work alternately #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Oct 31, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Oct 31, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Oct 31, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 1, 2022
|
It is failing a check relating to the Screen.h constructor in src/graphics, may be due to the inclusion of HAS_SCREEN 0 in the variant file. Not sure how to fix that, but I'd like to get this merged so I no longer have to deal with developing on my personal repo's master branch. |
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 1, 2022
|
These stub constructors are a shim to make the compiler happy. the declaration is 'not clean' cause it doesn't matter anyway. it's indeed the NO_SCREEN setting. Trying to make cppcheck not compain any more. |
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized my variant.h file so pins shared in common are at the top of the file, and the module-specific pins are in their own blocks.
Currently the M22S is initialized and can transmit.