[modules][external notifications] allow select channel to listen to #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesykm
commented
Oct 31, 2022
| @@ -157,15 +158,15 @@ extern "C" { | |||
| #define ModuleConfig_init_default {0, {ModuleConfig_MQTTConfig_init_default}} | |||
| #define ModuleConfig_MQTTConfig_init_default {0, "", "", "", 0, 0} | |||
| #define ModuleConfig_SerialConfig_init_default {0, 0, 0, 0, _ModuleConfig_SerialConfig_Serial_Baud_MIN, 0, _ModuleConfig_SerialConfig_Serial_Mode_MIN} | |||
| #define ModuleConfig_ExternalNotificationConfig_init_default {0, 0, 0, 0, 0, 0} | |||
| #define ModuleConfig_ExternalNotificationConfig_init_default {0, 0, 0, 0, 0, 0, "gpio"} | |||
There was a problem hiding this comment.
This is where old default value is set according to "proto 3" syntax.
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Oct 31, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 2, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 2, 2022
lesykm
force-pushed
the
ext_notification_channel
branch
from
35f7077 to
25a3a09
Compare
|
Updated to what @caveman99 suggested - listen on gpio channel only if alert_message is defined otherwise listen on all channels. No config changes. |
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 3, 2022
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Nov 3, 2022
caveman99
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1881
By default external notifications channel is bound to GPIO while canned messages (including bells) are sent to non-gpio channels essentially making inter-operation between these modules unusable.
Adding this new parameter (with default to old value, so no behavior change) will add ability to change bound channel so listen for bell character/any message on any other channel of choice.
meshtastic/protobufs#229 is prerequisite for this.