Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use RF95_IRQ for wakeup source in doLightSleep #1899

Merged
merged 6 commits into from
Nov 5, 2022

Conversation

weber-software
Copy link
Contributor

@weber-software weber-software commented Nov 4, 2022

This PR fixes the wakeup of RF95 based boards from light sleep by the RF95.

The configuration name of the IRQ from RF95Configuration.h pin is RF95_IRQ and not RF95_IRQ_GPIO.

Without the PR my device is missing most of the messages while in light sleep mode.

With this PR my device is able to receive the messages and successfully acknowledges them.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2022

CLA assistant check
All committers have signed the CLA.

@caveman99
Copy link
Member

just out of curiousity - which device is this?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

🤖 Pull request artifacts

file commit
pr1899-firmware-2.0.0.55cf538.zip 55cf538

thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 4, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 4, 2022
thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 5, 2022
@weber-software
Copy link
Contributor Author

@caveman99 Its a T-Beam V1.1

thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 5, 2022
@thebentern thebentern merged commit ed26ab8 into meshtastic:master Nov 5, 2022
@weber-software weber-software deleted the fix-rf95-wakeup branch November 5, 2022 13:38
thebentern added a commit that referenced this pull request Nov 5, 2022
* Rearranging deck chairs, 900M22S working, 30S not

* We do have wire, just not where it's expected

* Put more of the module specific pins in their blocks

* tryfix compile with NO_SCREEN

* Portduino only: don't continue to try rebooting (#1887)

Co-authored-by: Thomas Göttgens <[email protected]>

* Support for TLORA 2.1-1.8

* Don't allow arbitrary channel name for admin (#1886)

Co-authored-by: Ben Meadors <[email protected]>

* Experimental DIY nrf52840 feather support (#1884)

* Experimental DIY nrf52840 feather support

* Fix target

* sx1262 wiring

* Remove lib

* Don't consider Response as ACK for FloodingRouter (#1885)

Co-authored-by: Ben Meadors <[email protected]>

* Fix feather diy (#1892)

* Fix variant

* Fix feather diy target

* [modules][external notifications] allow select channel to listen to

* Fix feather diy pin mapping (#1894)

Thanks to @markbirss

* [create-pull-request] automated change

* Override Screen Autodtect

* Maybe fix crash of this board.

* Fixes reset loop with new espressif32 platform on tlora-v2

 Sending a pulse to the OLED_RESET Pin 16 results in a reset loop using recent version of the espressif32 platform.

* Experiment with self hosted action runner

* Fix MQTT on ETH

* revert the tryfix

* Cheating

* Cleanup artifacts older than 1 month

* Update cleanup_artifacts.yml

* Update cleanup_artifacts.yml

* Update cleanup_artifacts.yml

* Delete cleanup_artifacts.yml

* fix: use RF95_IRQ for wakeup source in doLightSleep (#1899)

Co-authored-by: Thomas Göttgens <[email protected]>
Co-authored-by: Ben Meadors <[email protected]>

* Update protos

* Update protos

Co-authored-by: code8buster <[email protected]>
Co-authored-by: Thomas Göttgens <[email protected]>
Co-authored-by: GUVWAF <[email protected]>
Co-authored-by: Mykhailo Lesyk <[email protected]>
Co-authored-by: Mykhailo Lesyk <[email protected]>
Co-authored-by: caveman99 <[email protected]>
Co-authored-by: he-leon <[email protected]>
Co-authored-by: Lars Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants