Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tbeam-s3 variant #1936

Merged
merged 11 commits into from
Nov 12, 2022
Merged

Update tbeam-s3 variant #1936

merged 11 commits into from
Nov 12, 2022

Conversation

lewisxhe
Copy link
Contributor

Make the following updates according to the update of the board

  1. Update the final t-beam-s3-core pin mapping
  2. The initialization of SD card is added to FSCommon. Because there is no function definition for SD card in 'meshtastic', only initialization is added. HSPI is used
  3. Change PCF8563 RTC from Wire to Wire1, PCF8563 shares I2C bus with PMU
  1. Add ESP32S3 low-speed crystal initialization, which can effectively reduce RTC clock drift during deep sleep

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2022 •
edited
Loading

🤖 Pull request artifacts

file commit
pr1936-firmware-2.0.3.67efd81.zip 60fdf9f

thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 12, 2022
@thebentern
Upload pr1936-firmware-2.0.3.43f769e.zip (43f76)
d5d5ac1 
Pull request: meshtastic/firmware#1936
Commit: meshtastic/firmware@43f769e
caveman99
caveman99 requested changes Nov 12, 2022
View reviewed changes
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, can we find a solution for the screen scanning? If not, we need to alter the logic for the PIN determination.

src/main.cpp Outdated Show resolved Hide resolved
thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 12, 2022
@thebentern
Upload pr1936-firmware-2.0.3.67efd81.zip (67efd)
258bad5 
Pull request: meshtastic/firmware#1936
Commit: meshtastic/firmware@67efd81
thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 12, 2022
@thebentern
Upload pr1936-firmware-2.0.3.67efd81.zip (60fdf)
9a8f55f 
Pull request: meshtastic/firmware#1936
Commit: meshtastic/firmware@60fdf9f
@caveman99 caveman99 self-requested a review November 12, 2022 13:11
@caveman99 caveman99 merged commit 4f60fad into meshtastic:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caveman99 caveman99 caveman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewisxhe @caveman99