Enable GPS capabilities on heltec V3 #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Dec 13, 2022
caveman99
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Looks good to me
@thebentern on the next alpha we should do that for all devices that don't have a GPS chip soldered on. Remove the RX/TX defines from the device file and document the proto settings instead. nRF52 does not apply as that uses the hw serial anyway and ignores these.
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/heltec-esp32-lora-v3-gps/7024/2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heltec V3 variant had HAS_GPS set to disable GPS capabilities. I've tested with this enabled and using GPIO 2 and 3 via config params.