Don't send NodeInfo and DeviceTelemetry at high Tx air utilization #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move airtime checking to airtime class
thebentern
approved these changes
Jan 11, 2023
🤖 Pull request artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, if you are duty cycle restricted, you won’t send the NodeInfo and DeviceTelemetry over the mesh when your Tx air utilization is higher than 5% (50% of the duty cycle limit). This will decrease the chance of hitting the limit, whilst missing less important packets than e.g. text or position.
Also moved the other airtime checks to the Airtime class. (And let portduino send DeviceTelemetry as well.)