Enable DeviceTelemetry on Portduino #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To separate DeviceTelemetry and EnvironmentTelemetry
To use notifyLater when transmitting, fixes packetPool issues
Breaks when running since mesh/http is not compiled
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Feb 11, 2023
caveman99
approved these changes
Feb 11, 2023
|
Good stuff, the syslog problem may be related to the PIC PIE error message. Since portduino has IP by default, it would be a shame to have to exclude that. Let's keep in mind we have tofix that underlying problem eventually. |
caveman99
approved these changes
Feb 11, 2023
thebentern
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
HAS_SENSORflag to separate DeviceTelemetry from EnvironmentTelemetry such that we can enable it on Portduino.Furthermore, I had to put
SimRadioin a separate thread such that I can usenotifyLaterwhen transmitting, to fix issues with the packetPool when it was usingccToPhonefor DeviceTelemetry.I also guarded the simulator stuff with
HAS_RADIOsuch that we can distinguish between a Portduino target with radio and the simulator.Then I found syslog causes Portduino to crash because it doesn't compile mesh/http, so I disabled that with an extra
!defined(ARCH_PORTDUINO).