Use LORA_DIO1 as RadioLib GPIO for SX127x chips #2290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set the LORA_DIO1 pin as the GPIO for RadioLib when using the RF95Interface, which we also use for boards with pure SX127x chip. The function
startChannelScan
relies on it, so otherwise channel activity detection doesn’t work. I confirmed it to be working after this with two T-Beams (using a long preamble) when trying to send at the same time by looking at the waterfall with an SDR.For boards with real RF95, this pin is not connected. Unfortunately I also found that for some TTGO LoRa32 boards this pin has to be wired manually.
Please check the new pin configurations. Since the only devices with a SX127x I have are T-Beams, I didn’t test other hardware. For the Heltec v1 I set the LORA_DIO1 as RADIOLIB_NC as otherwise it would overlap with GPS_TX_PIN.
This should really increase the reliability of messaging. Unfortunately it looks like channel activity detection also doesn’t work with SX126x. This might be related to
startReceive
(as opposed tostartReceiveDutyCycleAuto
) not working either.