Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- implement shutdown (deep sleep forever) on ESP32 #2352

Merged
merged 6 commits into from
Mar 12, 2023
Merged

- implement shutdown (deep sleep forever) on ESP32 #2352

merged 6 commits into from
Mar 12, 2023

Conversation

caveman99
Copy link
Member

  • Clean up shutdown and delayed shutdown code conditionals.
  • clean up inputbroker includes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2023 •
edited
Loading

🤖 Pull request artifacts

file commit
pr2352-firmware-2.1.2.09ea2e7.zip 09ea2e7

thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 11, 2023
@thebentern
Upload pr2352-firmware-2.1.2.8aa8b17.zip (8aa8b)
17c4f53 
Pull request: meshtastic/firmware#2352
Commit: meshtastic/firmware@8aa8b17
@caveman99 caveman99 requested review from thebentern and garthvh March 11, 2023 22:39
@caveman99
Copy link
Member Author

this implements #2326

@garthvh
Copy link
Member

garthvh commented Mar 11, 2023

Yay!

thebentern
thebentern approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@thebentern thebentern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing I'd add is make sure to add the HAS_CPU_SHUTDOWN to architecture.h for esp32 platform like we have in NRF for metadata responses so clients can know that they can now send shutdown admin messages

@mc-hamster
Copy link
Member

"woops" ... lol :)

thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 12, 2023
@thebentern
Upload pr2352-firmware-2.1.2.09ea2e7.zip (09ea2)
efd3975 
Pull request: meshtastic/firmware#2352
Commit: meshtastic/firmware@09ea2e7
@caveman99 caveman99 merged commit 6d20215 into master Mar 12, 2023
@caveman99 caveman99 deleted the feature-2326 branch March 12, 2023 19:22
@rpsainio rpsainio mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern thebentern approved these changes

@garthvh garthvh garthvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caveman99 @garthvh @mc-hamster @thebentern