Added t-beam v1.2 support #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
caveman99
requested changes
Mar 27, 2023
There was a problem hiding this comment.
PR looks fine to me, just a request. Can you change the macro conditionals to use the model specific HW_VENDOR tags? This way another vendor that chooses to use these chips can implement their own pin assignments.
for Tbeam HW_VENDOR is meshtastic_HardwareModel_TBEAM
and for the s3 core HW_VENDOR is meshtastic_HardwareModel_LILYGO_TBEAM_S3_CORE
|
@caveman99 done |
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 27, 2023
caveman99
approved these changes
Mar 27, 2023
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement version of tbeam v1.1 was changed from the AXP192 PMU to the AXP2101, with only minor changes The remaining GPIO has not changed