DIY external power pin #2398
Merged
DIY external power pin #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 31, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Mar 31, 2023
caveman99
approved these changes
Mar 31, 2023
|
@caveman99, thank you for fixing formatting. I build on Windows machine where trunk extension is not available. Is there other way to check code style without this Trunk extension on Windows? |
|
@osmanovv i use windows too, i have a WSL2 window running ubuntu and use trunk in there. the windows filesystems are available inside WSL under /mnt/ |
|
Thank you! I have just managed how to run it in WSL:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues such as unexpected node sleep, WiFi disconnection.
On some boards (DIY boards with ESP32 DevKit and LILYGO® TTGO T-Energy T18) we don't have a power management chip (like AXPxxxx) so we use GPIO pin
EXT_PWR_DETECTto detect the external power supply.To detect an external power supply, we need to pull up the
EXT_PWR_DETECTpin on the board.